Support loading env vars from secret files #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1994 +/- ##
==========================================
Coverage 96.90% 96.90%
- Complexity 1342 1346 +4
==========================================
Files 247 247
Lines 4654 4660 +6
==========================================
+ Hits 4510 4516 +6
Misses 144 144 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1868
This PR updates how environment variables are read, so that, if the actual env var is not found, it tries to read the equivalent env var but with the
_FILEsuffix.This way, if for example,
DB_PASSWORDis not set, butDB_PASSWORD_FILEis, we treat the value as a file path, read it, and return its contents as theDB_PASSWORDvalue.Regular env vars will always take precedence, so if both
DB_PASSWORDandDB_PASSWORD_FILEare set, the latter will be ignored.